linux-kernel - Re: [PATCH v2] scsi: core: Do not retry I/Os during depopulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f6c65f7-2042-44af-8080-5737542e048b@acm.org>
Date: Wed, 5 Feb 2025 10:13:58 -0800
From: Bart Van Assche <bvanassche@....org>
To: Igor Pylypiv <ipylypiv@...gle.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Douglas Gilbert <dgilbert@...erlog.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH v2] scsi: core: Do not retry I/Os during depopulation

On 1/31/25 10:44 AM, Igor Pylypiv wrote:
> Fail I/Os instead of retry to prevent user space processes from being
> blocked on the I/O completion for several minutes.
> 
> Retrying I/Os during "depopulation in progress" or "depopulation restore
> in progress" results in a continuous retry loop until the depopulation
> completes or until the I/O retry loop is aborted due to a timeout by
> the scsi_cmd_runtime_exceeced().
> 
> Depopulation is slow and can take 24+ hours to complete on 20+ TB HDDs.
> Most I/Os in the depopulation retry loop end up taking several minutes
> before returning the failure to user space.

Reviewed-by: Bart Van Assche <bvanassche@....org>