linux-kernel - Re: [PATCH net-next] net: renesas: rswitch: cleanup max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18a72981-9896-4725-8f5b-5783224de300@lunn.ch>
Date: Wed, 5 Feb 2025 20:35:09 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Michael Dege <michael.dege@...esas.com>,
	Christian Mardmoeller <christian.mardmoeller@...esas.com>,
	Dennis Ostermann <dennis.ostermann@...esas.com>
Subject: Re: [PATCH net-next] net: renesas: rswitch: cleanup max_speed setting

> +	err = of_get_phy_mode(rdev->np_port, &etha->phy_interface);
>  	if (err)
>  		return err;
>  
> -	err = of_property_read_u32(rdev->np_port, "max-speed", &max_speed);
> -	if (!err) {
> -		rdev->etha->speed = max_speed;
> -		return 0;
> -	}
> -
> -	/* if no "max-speed" property, let's use default speed */
> -	switch (rdev->etha->phy_interface) {
> -	case PHY_INTERFACE_MODE_MII:
> -		rdev->etha->speed = SPEED_100;
> -		break;
> +	switch (etha->phy_interface) {
>  	case PHY_INTERFACE_MODE_SGMII:
> -		rdev->etha->speed = SPEED_1000;
> +		etha->max_speed = SPEED_1000;
>  		break;
>  	case PHY_INTERFACE_MODE_USXGMII:
> -		rdev->etha->speed = SPEED_2500;
> +	case PHY_INTERFACE_MODE_5GBASER:
> +		etha->max_speed = SPEED_2500;

If the interface mode is 5GBASER why set the speed to SPEED_2500?
Also, USXGMII allows up to 10G. So this all looks a bit odd.

	Andrew