linux-kernel - Re: [PATCH v5 00/24] Intel vendor events and TMA 5.01 metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fUjx3PTHfjgkam9Q0xE+TrYx+FSzF8wUscbD9X36gJ1Tg@mail.gmail.com>
Date: Wed, 5 Feb 2025 12:47:38 -0800
From: Ian Rogers <irogers@...gle.com>
To: "Falcon, Thomas" <thomas.falcon@...el.com>
Cc: "Baker, Edward" <edward.baker@...el.com>, 
	"alexander.shishkin@...ux.intel.com" <alexander.shishkin@...ux.intel.com>, 
	"Biggers, Caleb" <caleb.biggers@...el.com>, "mpetlan@...hat.com" <mpetlan@...hat.com>, 
	"Taylor, Perry" <perry.taylor@...el.com>, "Hunter, Adrian" <adrian.hunter@...el.com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "mingo@...hat.com" <mingo@...hat.com>, 
	"linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>, 
	"kan.liang@...ux.intel.com" <kan.liang@...ux.intel.com>, 
	"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>, 
	"peterz@...radead.org" <peterz@...radead.org>, "Alt, Samantha" <samantha.alt@...el.com>, 
	"mark.rutland@....com" <mark.rutland@....com>, "Wang, Weilin" <weilin.wang@...el.com>, 
	"acme@...nel.org" <acme@...nel.org>, "afaerber@...e.de" <afaerber@...e.de>, 
	"jolsa@...nel.org" <jolsa@...nel.org>, "namhyung@...nel.org" <namhyung@...nel.org>
Subject: Re: [PATCH v5 00/24] Intel vendor events and TMA 5.01 metrics

On Wed, Feb 5, 2025 at 11:44 AM Falcon, Thomas <thomas.falcon@...el.com> wrote:
>
> On Wed, 2025-02-05 at 09:31 -0800, Ian Rogers wrote:
> > Update the Intel vendor events to the latest.
> > Update the metrics to TMA 5.01.
> > Add Arrowlake and Clearwaterforest support.
> > Add metrics for LNL and GNR.
> > Address IIO uncore issue spotted on EMR, GRR, GNR, SPR and SRF.
> >
> > The perf json was generated using the script:
> > https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
> > with the generated json being in:
> > https://github.com/intel/perfmon/tree/main/scripts/perf
> >
> > Thanks to Perry Taylor <perry.taylor@...el.com>, Caleb Biggers
> > <caleb.biggers@...el.com>, Edward Baker <edward.baker@...el.com>,
> > Weilin Wang <weilin.wang@...el.com>, Kan Liang
> > <kan.liang@...ux.intel.com> and Thomas Falcon
> > <thomas.falcon@...el.com> for helping get this patch series together.
> >
> > v5: Remove Valkyrie metrics mistakenly added on atom. Ensure "perf
> > all
> >     metrics test" doesn't skip for missing events.
> > v4: Fix TSC events on hybrid mistakenly specifying the core PMU
> >     inhibiting the use of the msr PMU.
> > v3: Fixes for hybrid metrics that were missing PMU. Update to the
> >     latest events.
> > v2: Fix hybrid and Co-authored-by tag issues reported by
> >     Arnaldo. Updates to Lunarlake and Meteorlake events. Addition of
> >     Clearwaterforest.
> >
>
> Thanks, I'm seeing some errors during the perf all metrics test:
>
> Metric 'tma_info_system_cpus_utilized' not printed in:
> event syntax error: '{cpu_core/TSC,metric-
> id=cpu_core!3TSC!3/,cpu_core/CPU_CL..'
>                       \___ Bad event or PMU
>
> Unable to find PMU or event on a PMU of 'cpu_core'
>
> event syntax error: '{cpu_core/TSC,metric-
> id=cpu_core!3TSC!3/,cpu_core/CPU_CL..'
>                                \___ unknown term 'TSC' for pmu
> 'cpu_core'
>
> valid terms:
> event,pc,edge,offcore_rsp,ldlat,inv,umask,frontend,cmask,config,config1
> ,config2,config3,name,period,percore,metric-id
>
> event syntax error: '{cpu_core/TSC,metric-
> id=cpu_core!3TSC!3/,cpu_core/CPU_CL..'
>                                \___ unknown term 'TSC' for pmu
> 'cpu_core'
>
> valid terms:
> event,pc,edge,offcore_rsp,ldlat,inv,umask,frontend,cmask,config,config1
> ,config2,config3,name,period,percore,metric-id
>
> There are all some errors like this,
>
> Testing tma_cisc
> Metric contains missing events
> Cannot resolve IDs for tma_cisc: cpu_atom@...DOWN_FE_BOUND.CISC@ / (5 *
> cpu_atom@..._CLK_UNHALTED.CORE@)
>

Thanks, I forgot to reapply the TSC fix. You can do it with
$ find tools/perf/pmu-events/arch/x86 -type f -exec sed -i
's/cpu_core@TSC@...C/g' {} \;
I can't eyeball this later missing events problem. What model type
does it happen on?

Thanks,
Ian