linux-kernel - Re: [PATCH net-next] net: renesas: rswitch: cleanup max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04f35c2f-f6ab-4fec-b282-e04c9008e47b@lunn.ch>
Date: Wed, 5 Feb 2025 22:28:10 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Michael Dege <michael.dege@...esas.com>,
	Christian Mardmoeller <christian.mardmoeller@...esas.com>,
	Dennis Ostermann <dennis.ostermann@...esas.com>
Subject: Re: [PATCH net-next] net: renesas: rswitch: cleanup max_speed setting

On Wed, Feb 05, 2025 at 09:26:10PM +0100, Nikita Yushchenko wrote:
> > If the interface mode is 5GBASER why set the speed to SPEED_2500?
> > Also, USXGMII allows up to 10G. So this all looks a bit odd.
> 
> 2500 is hardware limit (or at least the datasheet states so).

Then it should return -EINVAL if the device tree has a phy-mode the
hardware does not support.

USXGMII is maybe a bit harder, since i don't know if the higher speeds
are optional, but my understanding is that USXGMII allows up to
10G. Is it really using USXGMII, or 2500BaseX?

	Andrew