linux-kernel - Re: [PATCH AUTOSEL 6.13 06/16] tool api fs: Correctly encode errno for read/write open failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6Pd0oU4sa0OBxp3@lappy>
Date: Wed, 5 Feb 2025 16:53:22 -0500
From: Sasha Levin <sashal@...nel.org>
To: Namhyung Kim <namhyung@...il.com>
Cc: Ian Rogers <irogers@...gle.com>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Arnaldo Carvalho de Melo <acme@...hat.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
	Ben Gainey <ben.gainey@....com>,
	Colin Ian King <colin.i.king@...il.com>,
	Dominique Martinet <asmadeus@...ewreck.org>,
	Ilkka Koskinen <ilkka@...amperecomputing.com>,
	Ingo Molnar <mingo@...hat.com>,
	James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Mark Rutland <mark.rutland@....com>,
	Oliver Upton <oliver.upton@...ux.dev>,
	Paran Lee <p4ranlee@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"Steinar H . Gunderson" <sesse@...gle.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Falcon <thomas.falcon@...el.com>,
	Weilin Wang <weilin.wang@...el.com>,
	Yang Jihong <yangjihong@...edance.com>,
	Yang Li <yang.lee@...ux.alibaba.com>, Ze Gao <zegao2021@...il.com>,
	Zixian Cai <fzczx123@...il.com>,
	zhaimingbing <zhaimingbing@...s.chinamobile.com>
Subject: Re: [PATCH AUTOSEL 6.13 06/16] tool api fs: Correctly encode errno
 for read/write open failures

On Sun, Jan 26, 2025 at 12:41:31PM -0800, Namhyung Kim wrote:
>Hello,
>
>On Sun, Jan 26, 2025 at 10:27 AM Ian Rogers <irogers@...gle.com> wrote:
>>
>> On Sun, Jan 26, 2025 at 7:07 AM Sasha Levin <sashal@...nel.org> wrote:
>> >
>> > From: Ian Rogers <irogers@...gle.com>
>> >
>> > [ Upstream commit 05be17eed774aaf56f6b1e12714325ca3a266c04 ]
>> >
>> > Switch from returning -1 to -errno so that callers can determine types
>> > of failure.
>>
>> Hi Sasha,
>>
>> This change requires changes in the perf tool. The issue is the -1
>> gets written to perf.data files in the topology, the -errno value is
>> "corrupt." Because of this, I'd suggest not backporting this change.
>
>Agreed.  Please remove this patch from the all stable series.

I'll drop it, thanks!

-- 
Thanks,
Sasha