linux-kernel - Re: [PATCH 00/15] kasan: x86: arm64: risc-v: KASAN tag-based mode for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+fCnZd1dpqv+rM2jD1fNGvhU_0+6c8MjzsgEsi2V-RkHVteJg@mail.gmail.com>
Date: Thu, 6 Feb 2025 00:40:59 +0100
From: Andrey Konovalov <andreyknvl@...il.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>
Cc: luto@...nel.org, xin@...or.com, kirill.shutemov@...ux.intel.com, 
	palmer@...belt.com, tj@...nel.org, brgerst@...il.com, ardb@...nel.org, 
	dave.hansen@...ux.intel.com, jgross@...e.com, will@...nel.org, 
	akpm@...ux-foundation.org, arnd@...db.de, corbet@....net, dvyukov@...gle.com, 
	richard.weiyang@...il.com, ytcoode@...il.com, tglx@...utronix.de, 
	hpa@...or.com, seanjc@...gle.com, paul.walmsley@...ive.com, 
	aou@...s.berkeley.edu, justinstitt@...gle.com, jason.andryuk@....com, 
	glider@...gle.com, ubizjak@...il.com, jannh@...gle.com, bhe@...hat.com, 
	vincenzo.frascino@....com, rafael.j.wysocki@...el.com, 
	ndesaulniers@...gle.com, mingo@...hat.com, catalin.marinas@....com, 
	junichi.nomura@....com, nathan@...nel.org, ryabinin.a.a@...il.com, 
	dennis@...nel.org, bp@...en8.de, kevinloughlin@...gle.com, morbo@...gle.com, 
	dan.j.williams@...el.com, julian.stecklina@...erus-technology.de, 
	peterz@...radead.org, cl@...ux.com, kees@...nel.org, 
	kasan-dev@...glegroups.com, x86@...nel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, llvm@...ts.linux.dev, 
	linux-doc@...r.kernel.org
Subject: Re: [PATCH 00/15] kasan: x86: arm64: risc-v: KASAN tag-based mode for x86

On Tue, Feb 4, 2025 at 6:34 PM Maciej Wieczor-Retman
<maciej.wieczor-retman@...el.com> wrote:
>
> ======= Introduction
> The patchset aims to add a KASAN tag-based mode for the x86 architecture
> with the help of the new CPU feature called Linear Address Masking
> (LAM). Main improvement introduced by the series is 4x lower memory
> usage compared to KASAN's generic mode, the only currently available
> mode on x86.
>
> There are two logical parts to this series. The first one attempts to
> add a new memory saving mechanism called "dense mode" to the generic
> part of the tag-based KASAN code. The second one focuses on implementing
> and enabling the tag-based mode for the x86 architecture by using LAM.

Hi Maciej,

Awesome work! Great to see SW_TAGS mode supported on x86!

I started reviewing the patches, but this is somewhat complicated, as
the dense mode changes are squashed together with the generic ones for
x86 support. Could you please split this series into 2? Or at least
reorder the patches so that everything needed for basic x86 support
comes first and can be reviewed and tested separately.

I will post the comments for things I noted so far, including for the
dense mode changes, but I'll take a closer look after the split.

Also feel free to drop the dependency on that risc-v series, as it
doesn't get updated very often. But up to you.

And please also update all affected parts of Documentation/dev-tools/kasan.rst.

Thank you!