linux-kernel - Re: [PATCH] ASoC: max98095: Remove unused max98095_jack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6P7CaRSk4RD3jLc@gallifrey>
Date: Wed, 5 Feb 2025 23:58:01 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Mark Brown <broonie@...nel.org>
Cc: lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: max98095: Remove unused max98095_jack_detect

* Dr. David Alan Gilbert (linux@...blig.org) wrote:
> * Mark Brown (broonie@...nel.org) wrote:
> > On Wed, Feb 05, 2025 at 01:44:58AM +0000, linux@...blig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > > 
> > > max98095_jack_detect() was added in 2012 as part of
> > > commit 9dd90c5db040 ("ASoC: max98095: add jack detection")
> > > but hasn't been used.
> > > 
> > > Remove it.
> > 
> > > -	max98095_report_jack(client->irq, component);
> > > -	return 0;
> > > -}
> > > -EXPORT_SYMBOL_GPL(max98095_jack_detect);
> > 
> > No, this is exported for machine drivers which might not be in tree.
> 
> Ah OK; of course it would be nice if they were in the tree.

Mark:
  Is that also true of mt6359_accdet_enable_jack_detect ?
I can't find any callers in tree.

Dave

> Thanks,
> 
> Dave
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/