linux-kernel - Re: [PATCH v9 3/6] Coresight: Introduce a new struct coresight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edf3cea0-b3da-4eb8-9200-e3c4d6e19b51@quicinc.com>
Date: Wed, 5 Feb 2025 12:09:02 +0800
From: Jie Gan <quic_jiegan@...cinc.com>
To: James Clark <james.clark@...aro.org>
CC: Tingwei Zhang <quic_tingweiz@...cinc.com>,
        Jinlong Mao
	<quic_jinlmao@...cinc.com>, <coresight@...ts.linaro.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        Suzuki K Poulose
	<suzuki.poulose@....com>,
        Mike Leach <mike.leach@...aro.org>,
        "Alexander
 Shishkin" <alexander.shishkin@...ux.intel.com>,
        Maxime Coquelin
	<mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>
Subject: Re: [PATCH v9 3/6] Coresight: Introduce a new struct coresight_path



On 2/1/2025 12:43 AM, James Clark wrote:
> 
> 
> On 24/01/2025 7:25 am, Jie Gan wrote:
>> Add 'struct coresight_path' to store the data that is needed by
>> coresight_enable_path/coresight_disable_path. The structure
>> will be transmitted to the helper and sink device to enable
>> related funcationalities.
>>
>> Signed-off-by: Jie Gan <quic_jiegan@...cinc.com>
>> ---
> [...]
>>       /*
>>        * If we still have access to the event_data via handle,
>> @@ -595,11 +599,11 @@ static void etm_event_stop(struct perf_event 
>> *event, int mode)
>>       if (!csdev)
>>           return;
>> -    path = etm_event_cpu_path(event_data, cpu);
>> -    if (!path)
>> +    cs_path = etm_event_cpu_path(event_data, cpu);
>> +    if (!cs_path)
> 
> I don't think renaming 'path' to 'cs_path' is worth the churn. It's in a 
> lot of places in this change, but I think path is already good enough.
> 
Yes, agree with you. It seems unnecessary. Will update it.

>>           return;
>> -    sink = coresight_get_sink(path);
>> +    sink = coresight_get_sink(cs_path->path);
> 
> coresight_get_sink() is always called with cs_path->path, so we might as 
> well make it take a whole path struct. The same with any of the other 
> functions that operate on path like coresight_get_source().
It's make sense for me and make codes easy to read. I will update it.

> 

Thanks,
Jie