linux-kernel - Re: [GIT PULL] kthreads fixes for v6.14-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250205050112.yqaq3vkopubegljz@lcpd911>
Date: Wed, 5 Feb 2025 10:31:12 +0530
From: Dhruva Gole <d-gole@...com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
CC: Frederic Weisbecker <frederic@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] kthreads fixes for v6.14-rc2

On Feb 04, 2025 at 11:06:57 -0800, Linus Torvalds wrote:
> On Tue, 4 Feb 2025 at 10:58, Frederic Weisbecker <frederic@...nel.org> wrote:
> >
> > - Properly handle return value when allocation fails for the preferred
> >   affinity.
> 
> Well, we have exactly one caller of this function, and that caller
> doesn't actually care about the return value.

Yeah that was my initial thought while sending the fix here:
https://lore.kernel.org/linux-kernel/20250204090838.214647-1-d-gole@ti.com/

This patch hasn't appeared in next yet (next-20250204) so I missed this thread.

> 
> The function is literally the "preferred" affinity. If the affinity
> setup fails, it's harmless.
> 
> Anyway, the fix doesn't look wrong, and I've pulled it, but it's just
> all very harmless. I think the "set but not used" error could have
> been fixed by just removing the 'ret' variable entirely.
> 
>                 Linus
> 

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated