linux-kernel - Re: [PATCH 2/2] tty: serial: samsung: add support for exynos7870

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250205-artichoke-gibbon-of-management-e9c5fc@krzk-bin>
Date: Wed, 5 Feb 2025 09:44:01 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kaustabh Chakraborty <kauschluss@...root.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Jiri Slaby <jirislaby@...nel.org>, Rob Herring <robh@...nel.org>, Conor Dooley <conor@...nel.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Sergey Lisov <sleirsgoevy@...il.com>, 
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 2/2] tty: serial: samsung: add support for exynos7870

On Tue, Feb 04, 2025 at 02:08:46AM +0530, Kaustabh Chakraborty wrote:
> Add serial UART support for Exynos7870. The FIFO sizes are not defined
> in the driver, and they must be provided in the devicetree with the
> samsung,uart-fifosize property.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@...root.org>
> ---
>  drivers/tty/serial/samsung_tty.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 210fff7164c138e315d20ccaa4a29ce6a7bb2dfe..c8607633fea40df2ec221cfd3653c726094127cb 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -2493,6 +2493,12 @@ static const struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = {
>  	.fifosize = { 64, 256, 16, 256 },
>  };
>  
> +static const struct s3c24xx_serial_drv_data exynos7870_serial_drv_data = {
> +	EXYNOS_COMMON_SERIAL_DRV_DATA,
> +	/* samsung,uart-fifosize must be specified in the device tree. */
> +	.fifosize = { 0 },
> +};

I don't see any difference against Exynos8895, so they look compatible.
Use Exynos8895 as fallback compatible, even though it is a bit reversed.

Best regards,
Krzysztof