linux-kernel - Re: [PATCH 2/2] usb: dwc3: exynos: add support for exynos7870

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250205-eager-ibex-of-pleasure-61e3bb@krzk-bin>
Date: Wed, 5 Feb 2025 09:47:19 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kaustabh Chakraborty <kauschluss@...root.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Rob Herring <robh@...nel.org>, Conor Dooley <conor@...nel.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Thinh Nguyen <Thinh.Nguyen@...opsys.com>, 
	Sergey Lisov <sleirsgoevy@...il.com>, linux-usb@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] usb: dwc3: exynos: add support for exynos7870

On Tue, Feb 04, 2025 at 02:09:30AM +0530, Kaustabh Chakraborty wrote:
> Exynos7870 devices have a DWC3 compatible USB 2.0 controller.
> Add support in the driver by:
>  - Adding its own compatible string, "samsung,exynos7870-dwusb2".
>  - Adding three USBDRD clocks named "usbdrd20", "usbdrd20_ctrl_clk", and
>    "usbdrd20_ref_clk", to be controlled by the driver.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@...root.org>
> ---
>  drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index f5d963fae9e069e1bd145ff5bd1b704da89fb74c..34f2b9e8529303cd2a957baed5819a45cbcf3309 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -163,6 +163,12 @@ static const struct dwc3_exynos_driverdata exynos7_drvdata = {
>  	.suspend_clk_idx = 1,
>  };
>  
> +static const struct dwc3_exynos_driverdata exynos7870_drvdata = {
> +	.clk_names = { "usbdrd20", "usbdrd20_ctrl_clk", "usbdrd20_ref_clk" },

We already stopped this mad downstream pattern, so don't reintroduce it.
Use proper names describing the purpose of the clock, not the source
name. See Exynos850 or GS101.

This is probably bus_early, "something?" and finally ref.

Best regards,
Krzysztof