linux-kernel - Re: [PATCH v1 15/29] cxl/region: Use an endpoint's SPA range to find a region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6MoveIYE2lcTdlT@rric.localdomain>
Date: Wed, 5 Feb 2025 10:00:45 +0100
From: Robert Richter <rrichter@....com>
To: Ben Cheatham <benjamin.cheatham@....com>
Cc: linux-cxl@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gregory Price <gourry@...rry.net>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
	Terry Bowman <terry.bowman@....com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>
Subject: Re: [PATCH v1 15/29] cxl/region: Use an endpoint's SPA range to find
 a region

On 17.01.25 15:31:43, Ben Cheatham wrote:
> On 1/7/25 8:10 AM, Robert Richter wrote:

> >  static int match_auto_decoder(struct device *dev, void *data)
> >  {
> >  	struct cxl_region_params *p = data;
> > @@ -3214,26 +3249,47 @@ cxl_port_find_switch_decoder(struct cxl_port *port, struct range *hpa)
> >  static int cxl_endpoint_initialize(struct cxl_endpoint_decoder *cxled)
> >  {
> >  	struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);
> > -	struct cxl_port *iter = cxled_to_port(cxled);
> > -	struct range *hpa = &cxled->cxld.hpa_range;
> > +	struct cxl_port *parent, *iter = cxled_to_port(cxled);
> > +	struct range hpa = cxled->cxld.hpa_range;
> >  	struct cxl_decoder *cxld = &cxled->cxld;
> 
> Can cut down on the dereferencing a bit here by doing:
> 	struct cxl_decoder *cxld = &cxled->cxld;
> 	struct range hpa = cxld->hpa_range;
> 
> instead.

Changed that, thanks.

-Robert