linux-kernel - Re: [PATCH v6 7/7] rtc: Add Nuvoton NCT6694 RTC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250205102214a6357365@mail.local>
Date: Wed, 5 Feb 2025 11:23:46 +0100
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Ming Yu <a0282524688@...il.com>
Cc: tmyu0@...oton.com, lee@...nel.org, linus.walleij@...aro.org,
	brgl@...ev.pl, andi.shyti@...nel.org, mkl@...gutronix.de,
	mailhol.vincent@...adoo.fr, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, wqlinux@...ck-us.net, jdelvare@...e.com,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-i2c@...r.kernel.org, linux-can@...r.kernel.org,
	netdev@...r.kernel.org, linux-watchdog@...r.kernel.org,
	linux-hwmon@...r.kernel.org, linux-rtc@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v6 7/7] rtc: Add Nuvoton NCT6694 RTC support

On 23/01/2025 17:11:15+0800, Ming Yu wrote:
> +	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> +					nct6694_irq, IRQF_ONESHOT,
> +					"rtc-nct6694", data);
> +	if (ret < 0)
> +		return dev_err_probe(&pdev->dev, ret, "Failed to request irq\n");
> +
> +	ret = devm_rtc_register_device(data->rtc);
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret, "Failed to register rtc\n");

This message is not necessary, all the error paths of
devm_rtc_register_device already print a message

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com