linux-kernel - RE: [PATCH 1/2] firmware: xilinx: Update the zynqmp_pm_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DS7PR12MB6070A83267558A7D545E3383CDF72@DS7PR12MB6070.namprd12.prod.outlook.com>
Date: Wed, 5 Feb 2025 11:32:53 +0000
From: "Manne, Nava kishore" <nava.kishore.manne@....com>
To: Jie Gan <jie.gan@....qualcomm.com>, "Simek, Michal"
	<michal.simek@....com>, "Jain, Ronak" <ronak.jain@....com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "Buddhabhatti,
 Jay" <jay.buddhabhatti@....com>, "praveen.teja.kundanala@....com"
	<praveen.teja.kundanala@....com>, "Paladugu, Siva Durga Prasad"
	<siva.durga.prasad.paladugu@....com>, "u.kleine-koenig@...libre.com"
	<u.kleine-koenig@...libre.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] firmware: xilinx: Update the zynqmp_pm_load_pdi() API

Hi Jie,

	Thanks for providing the review comments.
Please find my response inline.

> -----Original Message-----
> From: Jie Gan <jie.gan@....qualcomm.com>
> Sent: Friday, January 24, 2025 11:30 AM
> To: Manne, Nava kishore <nava.kishore.manne@....com>; Simek, Michal
> <michal.simek@....com>; Jain, Ronak <ronak.jain@....com>;
> gregkh@...uxfoundation.org; Buddhabhatti, Jay <jay.buddhabhatti@....com>;
> praveen.teja.kundanala@....com; Paladugu, Siva Durga Prasad
> <siva.durga.prasad.paladugu@....com>; u.kleine-koenig@...libre.com; linux-
> arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 1/2] firmware: xilinx: Update the zynqmp_pm_load_pdi() API
> 
> 
> 
> On 1/23/2025 6:35 PM, Nava kishore Manne wrote:
> > Update the zynqmp_pm_load_pdi() API to handle the firmware error’s
> > properly.
> >
> > Signed-off-by: Nava kishore Manne <nava.kishore.manne@....com>
> > ---
> >   drivers/firmware/xilinx/zynqmp.c | 12 ++++++++++--
> >   1 file changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/firmware/xilinx/zynqmp.c
> > b/drivers/firmware/xilinx/zynqmp.c
> > index 720fa8b5d8e9..ea04a6ac402d 100644
> > --- a/drivers/firmware/xilinx/zynqmp.c
> > +++ b/drivers/firmware/xilinx/zynqmp.c
> > @@ -1483,8 +1483,16 @@
> EXPORT_SYMBOL_GPL(zynqmp_pm_set_requirement);
> >    */
> >   int zynqmp_pm_load_pdi(const u32 src, const u64 address)
> >   {
> > -	return zynqmp_pm_invoke_fn(PM_LOAD_PDI, NULL, 3, src,
> lower_32_bits(address),
> > -				   upper_32_bits(address));
> > +	u32 ret_payload[PAYLOAD_ARG_CNT];
> > +	int ret;
> > +
> > +	ret = zynqmp_pm_invoke_fn(PM_LOAD_PDI, ret_payload, 3, src,
> > +				  lower_32_bits(address),
> > +				  upper_32_bits(address));
> > +	if (ret_payload[0])
> > +		return ret_payload[0];
> Looks a little bit hacking. As the ret_payload is u32, return as int, it has possibility to
> overflow?
> 
I agree with your concern.
I'll drop this patch and look into a proper solution to address the issue.

Regards,
Navakishore