linux-kernel - Re: [PATCH v2 14/45] rtc: class: Switch to use hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502051136068413540a@mail.local>
Date: Wed, 5 Feb 2025 12:36:06 +0100
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Nam Cao <namcao@...utronix.de>
Cc: Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Frederic Weisbecker <frederic@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Zack Rusin <zack.rusin@...adcom.com>
Subject: Re: [PATCH v2 14/45] rtc: class: Switch to use hrtimer_setup()

On 05/02/2025 11:46:02+0100, Nam Cao wrote:
> hrtimer_setup() takes the callback function pointer as argument and
> initializes the timer completely.
> 
> Replace hrtimer_init() and the open coded initialization of
> hrtimer::function with the new setup mechanism.
> 
> Patch was created by using Coccinelle.
> 
> Acked-by: Zack Rusin <zack.rusin@...adcom.com>
> Signed-off-by: Nam Cao <namcao@...utronix.de>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>

Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

> ---
>  drivers/rtc/class.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c
> index e31fa0ad127e..b88cd4fb295b 100644
> --- a/drivers/rtc/class.c
> +++ b/drivers/rtc/class.c
> @@ -240,8 +240,7 @@ static struct rtc_device *rtc_allocate_device(void)
>  	/* Init uie timer */
>  	rtc_timer_init(&rtc->uie_rtctimer, rtc_uie_update_irq, rtc);
>  	/* Init pie timer */
> -	hrtimer_init(&rtc->pie_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> -	rtc->pie_timer.function = rtc_pie_update_irq;
> +	hrtimer_setup(&rtc->pie_timer, rtc_pie_update_irq, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
>  	rtc->pie_enabled = 0;
>  
>  	set_bit(RTC_FEATURE_ALARM, rtc->features);
> -- 
> 2.39.5
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com