linux-kernel - RE: [PATCH] EDAC/igen6: Constify struct res

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY8PR11MB71341D7635A2609F90BDD92B89F72@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Wed, 5 Feb 2025 11:55:51 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, "Luck, Tony"
	<tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>, James Morse
	<james.morse@....com>, Mauro Carvalho Chehab <mchehab@...nel.org>, "Robert
 Richter" <rric@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: RE: [PATCH] EDAC/igen6: Constify struct res_config

> From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> [...]
> Subject: [PATCH] EDAC/igen6: Constify struct res_config
> 
> 'struct res_config' are not modified in this driver.
> 
> Constifying these structures moves some data to a read-only section, so
> increase overall security, especially when the structure holds some function
> pointers.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   36777	   2479	   4304	  43560	   aa28	drivers/edac/igen6_edac.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   37297	   1959	   4304	  43560	   aa28	drivers/edac/igen6_edac.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

LGTM, thanks!

    Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>