linux-kernel - Re: [PATCH] selftests: pidfd: Fix compiling errors and warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250205130756.7b7b4f7e@gmx.net>
Date: Wed, 5 Feb 2025 13:07:56 +0100
From: Peter Seiderer <ps.report@....net>
To: I Hsin Cheng <richard120310@...il.com>
Cc: shuah@...nel.org, brauner@...nel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] selftests: pidfd: Fix compiling errors and warning

Hello *,

On Wed,  5 Feb 2025 13:39:26 +0800, I Hsin Cheng <richard120310@...il.com> wrote:

> When compiling selftests files under tools/testing/selftests/pidfd/ ,
> some compiling errors and warnings will pop out as the following.
> 
>   CC       pidfd_fdinfo_test
> pidfd_fdinfo_test.c: In function ‘child_fdinfo_nspid_test’:
> pidfd_fdinfo_test.c:231:13: warning: implicit declaration of function \
> ‘mount’ [-Wimplicit-function-declaration]
>   231 |         r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0);
>       |             ^~~~~
> pidfd_fdinfo_test.c:231:36: error: ‘MS_REC’ undeclared \
> (first use in this function)
>   231 |         r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0);
>       |                                    ^~~~~~
> pidfd_fdinfo_test.c:231:36: note: each undeclared identifier is \
> reported only once for each function it appears in
> pidfd_fdinfo_test.c:231:45: error: ‘MS_PRIVATE’ undeclared \
> (first use in this function); did you mean ‘MAP_PRIVATE’?
>   231 |         r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0);
>       |                                             ^~~~~~~~~~
>       |                                             MAP_PRIVATE
> pidfd_fdinfo_test.c:237:15: warning: implicit declaration of function \
> ‘umount2’; did you mean ‘SYS_umount2’? \
> [-Wimplicit-function-declaration]
>   237 |         (void)umount2("/proc", MNT_DETACH);
>       |               ^~~~~~~
>       |               SYS_umount2
> pidfd_fdinfo_test.c:237:32: error: ‘MNT_DETACH’ undeclared \
> (first use in this function)
>   237 |         (void)umount2("/proc", MNT_DETACH);
>       |                                ^~~~~~~~~~
> make: *** [../lib.mk:222: \
> ~/linux/tools/testing/selftests/pidfd/pidfd_fdinfo_test] Error 1
> 
> Solve these errors and warnings by including header file <sys/mount.h>.
> 
> Signed-off-by: I Hsin Cheng <richard120310@...il.com>
> ---
>  tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
> index f062a986e..f718aac75 100644
> --- a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
> +++ b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
> @@ -13,6 +13,7 @@
>  #include <syscall.h>
>  #include <sys/wait.h>
>  #include <sys/mman.h>
> +#include <sys/mount.h>
>  
>  #include "pidfd.h"
>  #include "../kselftest.h"

Predated patch already available, see

	https://lore.kernel.org/linux-kselftest/20250115105211.390370-1-ps.report@gmx.net/

Regards,
Peter