linux-kernel - Re: [PATCH v2 1/1] checkpatch: strip comments fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72kN-FaciYLuv-mXHNGdN13UpvqoaRX=-0mKE4M9BdtY6Q@mail.gmail.com>
Date: Wed, 5 Feb 2025 13:55:16 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: albankurti <kurti@...icto.ai>
Cc: Joe Perches <joe@...ches.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Charalampos Mitrodimas <charmitro@...teo.net>, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>
Subject: Re: [PATCH v2 1/1] checkpatch: strip comments fix

Hi albankurti,

On Wed, Feb 5, 2025 at 1:05 PM albankurti <kurti@...icto.ai> wrote:
>
> Fixes the false positive warning when there is a comment on a pr_ or
> dev_ log that ends with \n correctly.
> Also contains some improvements on the macro_pattern to make it more
> concise.
>
> Suggested-by: Miguel Ojeda <ojeda@...nel.org>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1140
> Signed-off-by: albankurti <kurti@...icto.ai>

Thanks for the patch!

It seems this is v2 of:

    https://lore.kernel.org/rust-for-linux/20250203201149.330117-1-kurti@invicto.ai/

Is that correct?

If so, the commit title and description looks wrong, i.e. it seems
that you are explaining what it changed w.r.t. v2, but instead you
should put that in a changelog after the `---` line after the
Signed-off-by tag. The commit message and title should describe what
the commit does, just like v1 does.

Also, the kernel requires a "known identity" for signatures. For
instance, the name you use to sign documents in real life. Please let
us know if that is a problem -- see:

    https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Cheers,
Miguel