linux-kernel - Re: [PATCH V7 2/5] PCI/TPH: Add Steering Tag support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4294edaf-8621-41b2-9009-7f5f3bb6c7f8@arm.com>
Date: Wed, 5 Feb 2025 12:57:21 +0000
From: Robin Murphy <robin.murphy@....com>
To: Wei Huang <wei.huang2@....com>, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 netdev@...r.kernel.org
Cc: Jonathan.Cameron@...wei.com, helgaas@...nel.org, corbet@....net,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, alex.williamson@...hat.com, gospo@...adcom.com,
 michael.chan@...adcom.com, ajit.khaparde@...adcom.com,
 somnath.kotur@...adcom.com, andrew.gospodarek@...adcom.com,
 manoj.panicker2@....com, Eric.VanTassell@....com, vadim.fedorenko@...ux.dev,
 horms@...nel.org, bagasdotme@...il.com, bhelgaas@...gle.com,
 lukas@...ner.de, paul.e.luse@...el.com, jing2.liu@...el.com
Subject: Re: [PATCH V7 2/5] PCI/TPH: Add Steering Tag support

On 2025-02-04 8:18 pm, Wei Huang wrote:
> 
> 
> On 2/4/25 12:33 PM, Robin Murphy wrote:
>> On 2024-10-02 5:59 pm, Wei Huang wrote:
>> [...]
>>> +
>>> +    if (err) {
>>> +        pcie_disable_tph(pdev);
>>> +        return err;
>>> +    }
>>> +
>>> +    set_ctrl_reg_req_en(pdev, pdev->tph_mode);
>>
>> Just looking at this code in mainline, and I don't trust my
>> understanding quite enough to send a patch myself, but doesn't this want
>> to be pdev->tph_req_type, rather than tph_mode?
> 
> Yeah, you are right - this is supposed to be pdev->tph_req_type instead 
> of tph_mode. We disable TPH first by clearing (zero) the "TPH Requester 
> Enable" field and needs to set it back using tph_req_type.
> 
> Do you want to send in a fix? I can ACK it. Thanks for spotting it.

Done[1] - cheers for confirming!

Robin.


[1] 
https://lore.kernel.org/linux-pci/13118098116d7bce07aa20b8c52e28c7d1847246.1738759933.git.robin.murphy@arm.com/

> 
> -Wei
> 
>>
>> Thanks,
>> Robin.
>>