linux-kernel - [PATCH net-next v4 15/17] net: pktgen: num_arg error out in case no valid character is parsed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250205131153.476278-16-ps.report@gmx.net>
Date: Wed,  5 Feb 2025 14:11:51 +0100
From: Peter Seiderer <ps.report@....net>
To: netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Shuah Khan <shuah@...nel.org>,
	Peter Seiderer <ps.report@....net>
Subject: [PATCH net-next v4 15/17] net: pktgen: num_arg error out in case no valid character is parsed

In num_arg() error out in case no valid character is parsed.

Signed-off-by: Peter Seiderer <ps.report@....net>
---
Changes v3 -> v4
  - new patch (factored out of patch 'net: pktgen: fix access outside of user
    given buffer in pktgen_if_write()')
---
 net/core/pktgen.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index cb3b732fd0a3..a46eb20edf6c 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -821,6 +821,9 @@ static long num_arg(const char __user *user_buffer, unsigned long maxlen,
 		if ((c >= '0') && (c <= '9')) {
 			*num *= 10;
 			*num += c - '0';
+		} else if (i == 0) {
+			/* no valid character parsed, error out */
+			return -EINVAL;
 		} else
 			break;
 	}
-- 
2.48.1