linux-kernel - Re: [PATCH net-next v4 1/8] netconsole: consolidate send buffers into netconsole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250205133455.GD554665@kernel.org>
Date: Wed, 5 Feb 2025 13:34:55 +0000
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kselftest@...r.kernel.org,
	rdunlap@...radead.org, kernel-team@...a.com
Subject: Re: [PATCH net-next v4 1/8] netconsole: consolidate send buffers
 into netconsole_target struct

On Tue, Feb 04, 2025 at 03:35:09AM -0800, Breno Leitao wrote:
> Move the static buffers from send_msg_no_fragmentation() and
> send_msg_fragmented() into the netconsole_target structure. This
> simplifies the code by:
> - Eliminating redundant static buffers
> - Centralizing buffer management in the target structure
> - Reducing memory usage by 1KB (one buffer instead of two)
> 
> The buffer in netconsole_target is protected by target_list_lock,
> maintaining the same synchronization semantics as the original code.
> 
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> Reviewed-by: Simon Horman <horms@...nel.org>

Hi Breno,

Unfortunately this series did not apply to net-next cleanly,
which trips up the Netdev CI. Could you rebase and repost?

Also, one minor nit below.

> ---
>  drivers/net/netconsole.c | 30 ++++++++++++++++--------------
>  1 file changed, 16 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
> index 86ab4a42769a49eebe5dd6f01dafafc6c86ec54f..c1ad54d99438dbd14e8288d39ad6bcc6f8ff5ad1 100644
> --- a/drivers/net/netconsole.c
> +++ b/drivers/net/netconsole.c
> @@ -123,6 +123,7 @@ struct netconsole_target_stats  {
>   *		remote_ip	(read-write)
>   *		local_mac	(read-only)
>   *		remote_mac	(read-write)
> + * @buf		The buffer used to send the full msg to the network stack
>   */

Tooling seems to want this to be "@buf:" rather than "@buf".

Flagged by ./scripts/kernel-doc -none, and W=1 builds.

...

-- 
pw-bot: cr