linux-kernel - Re: [PATCH v3 0/2] objtool: Add option to fail build on vmlinux warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+i-1C1A_0nkY6G+W3n=dYqEJHZGuEwNXK=xrWNwDh7561x_9A@mail.gmail.com>
Date: Thu, 6 Feb 2025 16:05:01 +0100
From: Brendan Jackman <jackmanb@...gle.com>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Josh Poimboeuf <jpoimboe@...nel.org>, Peter Zijlstra <peterz@...radead.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, Masahiro Yamada <masahiroy@...nel.org>, 
	Nicolas Schier <nicolas@...sle.eu>, linux-kernel@...r.kernel.org, 
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH v3 0/2] objtool: Add option to fail build on vmlinux warnings

OK, it would be interesting to spend a couple of hours staring at
these errors and see if I can get a feel for the overal picture..

Also, now that I think about it I'm a bit embarrassed I didn't try
building allmodconfig before sending this series (maybe I had
forgotten it exists?)! Sorry about that :)

On Fri, 31 Jan 2025 at 21:49, Nathan Chancellor <nathan@...nel.org> wrote:
> > But I can also envisage a world where that creates exactly as much
> > work for you, just introducing Kconfig hackery for no reason!
>
> Such is the nature of such changes. It is not that big of a deal for us
> to work around in the short term but it would still need to be addressed
> pretty quickly at that point.

I can't quite parse what you're getting at here - is this an opinion
about the idea to depend on !COMPILE_TEST, and if so are you in favour
of it? My thinking is that if it defaults n and isn't in allmodconfig,
the only people who will turn it on are those who actively care about
clean objtool for their build. Which.. isn't really what we want long
term, but it's better than not having the option at all and is already
a step in the direction of something that can act as a "ratchet".

If not, I'll go ahead with the OBJTOOL_FLAGS thing. (Which is still a
nice step in that direction).