linux-kernel - Re: [PATCH] kvm: delete unused variables iommu_noncoherent in struct kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6TSR8UmtNNHFeUQ@google.com>
Date: Thu, 6 Feb 2025 07:16:23 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: fuqiang wang <fuqiang.wng@...il.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	wangfuqiang49 <wangfuqiang49@...com>
Subject: Re: [PATCH] kvm: delete unused variables iommu_noncoherent in struct kvm_arch

On Thu, Feb 06, 2025, fuqiang wang wrote:
> The code of legacy device assignment is deleted entirely in commit
> ad6260da1e23 ("KVM: x86: drop legacy device assignment") and the
> variable iommu_noncoherent in struct kvm_arch is also not referenced by
> any other code. So it is deleted in this patch.

Someone else beat you to it by a few weeks, I just haven't applied the patch
yet.  Thanks!

https://lore.kernel.org/all/20250124075055.97158-1-znscnchen@gmail.com

> 
> Signed-off-by: wangfuqiang49 <wangfuqiang49@...com>
> ---
>  arch/x86/include/asm/kvm_host.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index b15cde0a9b5c..98555afb6f10 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1354,7 +1354,6 @@ struct kvm_arch {
>  	u64 shadow_mmio_value;
>  
>  	struct iommu_domain *iommu_domain;
> -	bool iommu_noncoherent;
>  #define __KVM_HAVE_ARCH_NONCOHERENT_DMA
>  	atomic_t noncoherent_dma_count;
>  #define __KVM_HAVE_ARCH_ASSIGNED_DEVICE
> -- 
> 2.47.0
>