linux-kernel - Re: [PATCH v2 3/3] pci/msi: remove pci_msi_ignore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250206160242.GA985980@bhelgaas>
Date: Thu, 6 Feb 2025 10:02:42 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Roger Pau Monné <roger.pau@...rix.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xenproject.org, linux-pci@...r.kernel.org,
	Juergen Gross <jgross@...e.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v2 3/3] pci/msi: remove pci_msi_ignore_mask

On Thu, Feb 06, 2025 at 09:33:26AM +0100, Roger Pau Monné wrote:
> On Wed, Feb 05, 2025 at 09:17:31AM -0600, Bjorn Helgaas wrote:
> > Please run git log --oneline and match the subject line capitalization
> > style, i.e.,
> > 
> >   PCI/MSI: Remove ...
> > 
> > But it doesn't look like this actually *removes* the functionality, it
> > just implements it differently so it can be applied more selectively.
> > 
> > So maybe the subject should say something like "control use of MSI
> > masking per IRQ domain, not globally"
> 
> What about:
> 
> PCI/MSI: convert pci_msi_ignore_mask to per MSI domain flag
> 
> Which is slightly shorter?

Much better.  Also capitalize "Convert".