[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANiq72=opw-X6-qXCFsdtLw8FDOO5Ekvj9L-r_4LSwoNShjwEw@mail.gmail.com>
Date: Thu, 6 Feb 2025 17:05:35 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Daniel Almeida <daniel.almeida@...labora.com>
Cc: Guangbo Cui <2407018371@...com>, Miguel Ojeda <ojeda@...nel.org>, a.hindborg@...nel.org,
alex.gaynor@...il.com, aliceryhl@...gle.com, benno.lossin@...ton.me,
bjorn3_gh@...tonmail.mco, boqun.feng@...il.com, boris.brezillon@...labora.com,
dakr@...nel.org, gary@...yguo.net, gregkh@...uxfoundation.org,
linux-kernel@...r.kernel.org, rafael@...nel.org, robh@...nel.org,
rust-for-linux@...r.kernel.org, tmgross@...ch.edu
Subject: Re: [PATCH v6 2/3] rust: io: mem: add a generic iomem abstraction
On Thu, Feb 6, 2025 at 4:57 PM Daniel Almeida
<daniel.almeida@...labora.com> wrote:
>
> I know that we can’t really provide a message through build_error itself, hence my
> suggestion about the docs.
>
> I can send a patch if you agree, it will prevent this confusion from coming up in the
> future.
We have some docs in the Rust items and the crate -- perhaps those can
be improved (e.g. showing an example of the error that one would get)
or rearranged and then a note referencing those from Doc/rust/?
That would definitely help, at least those that read the docs (but not
everyone does, and even those that do may forget details, so it will
not fully prevent the issue).
Ideally we would get a better way to do this, perhaps assisted by the
compiler(s)/linker (`*_assert` in
https://github.com/Rust-for-Linux/linux/issues/354).
Thanks!
Cheers,
Miguel
Powered by blists - more mailing lists