linux-kernel - [PATCH v2 0/1] pwm: tiehrpwm: ensures that state.enabled is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250206031347.63700-1-rafael.v.volkmer@gmail.com>
Date: Thu,  6 Feb 2025 00:13:46 -0300
From: "Rafael V. Volkmer" <rafael.v.volkmer@...il.com>
To: ukleinek@...nel.org
Cc: linux-kernel@...r.kernel.org,
	linux-pwm@...r.kernel.org,
	rafael.v.volkmer@...il.com
Subject: [PATCH v2 0/1] pwm: tiehrpwm: ensures that state.enabled is 

Hi Uwe.

Thanks for the feedback! It was very constructive for improving the code!

I fixed the points you mentioned and hope you can review v2 of my patch!

Changes in v2:
- Adjusted the indentation reported by checkpatch.pl;
- Added the bitfield header to replace the register bit defines with GEN_MASK 
and FIELD_GET;
- Concentrated the use of clk_get_rate() only once, inside ehrpwm_get_state();
- Added the ehrpwm_get_state() function as part of the driver's fops, directly 
linked to .get_state;
- Now, the activation of clk_prepare_enable() when the pwm is already running 
is done before pwmchip_add(), and runtime_get_sync() after;
- Added comments for each new function;
- Added comments in specific areas of register manipulation, in order to make 
understanding how they work more intuitive;
- Removed unnecessary null pointer checks in functions and also improper 
returns; 
- I improved the commit message, as suggested.

Rafael V. Volkmer (1):
  pwm: tiehrpwm: ensures that state.enabled is synchronized in .probe()

 drivers/pwm/pwm-tiehrpwm.c | 202 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 201 insertions(+), 1 deletion(-)

-- 
2.25.1