linux-kernel - RE: [PATCH] drm/xe: Fix uninitialized pointer read in xe_vm_bind_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH0PR11MB5444102E18D922D2FF328077E5F62@CH0PR11MB5444.namprd11.prod.outlook.com>
Date: Thu, 6 Feb 2025 16:33:43 +0000
From: "Cavitt, Jonathan" <jonathan.cavitt@...el.com>
To: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@...il.com>, "De Marchi,
 Lucas" <lucas.demarchi@...el.com>, "thomas.hellstrom@...ux.intel.com"
	<thomas.hellstrom@...ux.intel.com>, "Vivi, Rodrigo" <rodrigo.vivi@...el.com>
CC: "airlied@...il.com" <airlied@...il.com>, "simona@...ll.ch"
	<simona@...ll.ch>, "intel-xe@...ts.freedesktop.org"
	<intel-xe@...ts.freedesktop.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Cavitt, Jonathan"
	<jonathan.cavitt@...el.com>
Subject: RE: [PATCH] drm/xe: Fix uninitialized pointer read in
 xe_vm_bind_kernel_bo

-----Original Message-----
From: Intel-xe <intel-xe-bounces@...ts.freedesktop.org> On Behalf Of Dheeraj Reddy Jonnalagadda
Sent: Thursday, February 6, 2025 5:47 AM
To: De Marchi, Lucas <lucas.demarchi@...el.com>; thomas.hellstrom@...ux.intel.com; Vivi, Rodrigo <rodrigo.vivi@...el.com>
Cc: airlied@...il.com; simona@...ll.ch; intel-xe@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@...il.com>
Subject: [PATCH] drm/xe: Fix uninitialized pointer read in xe_vm_bind_kernel_bo
> 
> xe_vm_bind_kernel_bo() declares the variable fence without initializing
> it. If an error occurs before fence is assigned a valid value, the
> function may return an uninitialized pointer.
> 
> Specifically, this can happen if:
> 
> - vm_bind_ioctl_ops_create() fails, leading to release_vm_lock error
>   path
> 
> Initialize fence to NULL at declaration.
> 
> Fixes: dcdd6b84d9ac ("drm/xe/pxp: Allocate PXP execution resources")
> Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@...il.com>

Fair enough.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@...el.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_vm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index d664f2e418b2..b6ca53ede904 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -3184,7 +3184,7 @@ struct dma_fence *xe_vm_bind_kernel_bo(struct xe_vm *vm, struct xe_bo *bo,
>  {
>  	struct xe_vma_ops vops;
>  	struct drm_gpuva_ops *ops = NULL;
> -	struct dma_fence *fence;
> +	struct dma_fence *fence = NULL;
>  	int err;
>  
>  	xe_bo_get(bo);
> -- 
> 2.34.1
> 
>