linux-kernel - Re: [PATCH v1 1/1] regmap: irq: Use one way of setting all bits in the register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a60ef2d-365b-49ea-99b1-b83faee910c2@sirena.org.uk>
Date: Thu, 6 Feb 2025 16:51:35 +0000
From: Mark Brown <broonie@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Matti Vaittinen <mazziesaccount@...il.com>,
	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH v1 1/1] regmap: irq: Use one way of setting all bits in
 the register

On Thu, Feb 06, 2025 at 06:29:33PM +0200, Andy Shevchenko wrote:
> Currently there are two ways of how we represent all bits set, i.e.
> UINT_MAX and GENMASK(31, 0). Use the latter as the single way of
> doing that, which is crystal clear on how many bits we are talking
> about.

I think I'd rather go to UINT_MAX since it's more obviously correct if
we see platforms with int that isn't 32 bits.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)