linux-kernel - Re: [PATCH] lib/crc-t10dif: remove digest and block size constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXGtmdCCXLrbcrmGaEZTfT6nz9P=FokdtHhjtuQooY3d0w@mail.gmail.com>
Date: Thu, 6 Feb 2025 17:57:27 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] lib/crc-t10dif: remove digest and block size constants

On Thu, 6 Feb 2025 at 17:39, Eric Biggers <ebiggers@...nel.org> wrote:
>
> On Thu, Feb 06, 2025 at 12:09:22PM +0100, Ard Biesheuvel wrote:
> > On Tue, 4 Feb 2025 at 21:11, Eric Biggers <ebiggers@...nel.org> wrote:
> > >
> > > From: Eric Biggers <ebiggers@...gle.com>
> > >
> > > These constants are only used in crypto/crct10dif_generic.c, and they
> > > are better off just hardcoded there.
> > >
> > > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> > > ---
> > >
> > > I'm planning to take this via the crc tree.
> > >
> >
> > Acked-by: Ard Biesheuvel <ardb@...nel.org>
> >
> > Could you remind me why we are keeping this driver?
> >
>
> I don't know.  I had to keep "crc32" and "crc32c" around for now because they
> are still used, and I just defaulted to doing the same for "crct10dif".  It
> *looks like* "crct10dif" is different and we could indeed safely remove it like
> I ended up doing for "crc64-rocksoft", though.  "crct10dif" has no remaining
> references in the kernel; it has no references in cryptsetup, iwd, or libell;
> and Debian Code Search doesn't find anything else.  It's over a decade old, so I
> was worried there was time for users to have crept in, but that doesn't seem to
> have happened.  So yeah, good idea.  I'll send a patch that removes it, with the
> device-mapper folks Cc'd in case they know of anything else.
>

Good idea.