linux-kernel - Re: [PATCH v17 1/1] mctp pcc: Implement MCTP over PCC Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2ab6aa8-c7c7-44c1-9490-178101f9d00e@amperemail.onmicrosoft.com>
Date: Thu, 6 Feb 2025 13:28:05 -0500
From: Adam Young <admiyo@...eremail.onmicrosoft.com>
To: Jeremy Kerr <jk@...econstruct.com.au>, admiyo@...amperecomputing.com,
 Matt Johnston <matt@...econstruct.com.au>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Sudeep Holla <sudeep.holla@....com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Huisong Li <lihuisong@...wei.com>
Subject: Re: [PATCH v17 1/1] mctp pcc: Implement MCTP over PCC Transport

Is that your only concern with this patch?  I think as the MCTP 
maintainer, your opinion is going to weigh heavily on whether this gets 
merged or not.  I am more than willing to spin up a new version of this 
but want to avoid unnecessary churn.

What else would need to happen in order for this to get ACKed at this point?

On 2/6/25 02:04, Jeremy Kerr wrote:
> Hi Adam,
>
> One minor note below if you end up re-rolling for other reasons, but
> regardless of that:
>
> Acked-by: Jeremy Kerr <jk@...econstruct.com.au>
>
>> +       /* ndev needs to be freed before the iomemory (mapped above) gets
>> +        * unmapped,  devm resources get freed in reverse to the order they
>> +        * are added.
>> +        */
>> +       rc = mctp_register_netdev(ndev, &mctp_netdev_ops, MCTP_PHYS_BINDING_PCC);
>> +       if (rc)
>> +               goto cleanup_netdev;
>> +       return  devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev);
> You seem to have a trigger-happy spacebar; there is another double-space
> creeping in here, after the 'return'.
>
> Cheers,
>
>
> Jeremy