linux-kernel - Re: [PATCH v2 0/7] driver core: auxiliary bus: add device creation helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1j8qqi2abp.fsf@starbuckisacylon.baylibre.com>
Date: Thu, 06 Feb 2025 19:32:26 +0100
From: Jerome Brunet <jbrunet@...libre.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Dave Ertman <david.m.ertman@...el.com>,  Ira Weiny
 <ira.weiny@...el.com>,  "Rafael J. Wysocki" <rafael@...nel.org>,  Stephen
 Boyd <sboyd@...nel.org>,  Arnd Bergmann <arnd@...db.de>,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/7] driver core: auxiliary bus: add device creation
 helper

On Thu 06 Feb 2025 at 19:23, Jerome Brunet <jbrunet@...libre.com> wrote:

> The suggestion for this change was initially discussed here: [1]
>
> This patchset adds and use a helper to create a simple auxiliary device.
> The goal is to remove boilerplate code that tends to get repeated for
> simple cases.
>
> Only the last change was tested on actual HW. The other usage of the helper
> have only been compile tested with x64_64 allmodconfig. There are many other
> simple cases of auxiliary device creation but those tend to use the
> 'container_of' trick to allocate the auxiliary device. It is possible to
> convert these drivers to use the provided helper but the conversion is
> slightly more complex.
>
> [1]: https://lore.kernel.org/linux-clk/df0a53ee859e450d84e81547099f5f36.sboyd@kernel.org

Hi Greg,

Since the examples of usage touch several subsystems, this should have
spamed a lot of people. I took the liberty to send this v2 to the same
people as the v1 only, to collect feedback on the core helper and get
this right first.

If you are fine with the change, I'll resend, spamming all the necessary
people.

>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
> Changes in v2:
> - Add usage examples, as requested.
> - Add 'id' as function parameter:  Adding the example usage showed that
>   handling IDA allocation was not appropriate and making the usage more
>   complex for simple use case.
> - Also add 'modname' as parameter: Most driver have been using
>   KBUILD_MODNAME and this actually rarely align with the driver name.
> - Link to v1: https://lore.kernel.org/r/20241210-aux-device-create-helper-v1-1-5887f4d89308@baylibre.com
>
> ---
> Jerome Brunet (7):
>       driver core: auxiliary bus: add device creation helper
>       reset: mpfs: use the auxiliary device creation helper
>       drm/bridge: ti-sn65dsi86: use the auxiliary device creation helper
>       platform: arm64: lenovo-yoga-c630: use the auxiliary device creation helper
>       clk: eyeq: use the auxiliary device creation helper
>       clk: clk-imx8mp-audiomix: use the auxiliary device creation helper
>       clk: amlogic: axg-audio: use the auxiliary reset driver - take 2
>
>  drivers/base/auxiliary.c                  |  88 +++++++++++++++++++++++
>  drivers/clk/clk-eyeq.c                    |  57 ++++-----------
>  drivers/clk/imx/clk-imx8mp-audiomix.c     |  57 ++-------------
>  drivers/clk/meson/Kconfig                 |   2 +-
>  drivers/clk/meson/axg-audio.c             | 114 ++++--------------------------
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c     |  88 +++++++----------------
>  drivers/platform/arm64/lenovo-yoga-c630.c |  43 ++---------
>  drivers/reset/reset-mpfs.c                |  53 ++------------
>  include/linux/auxiliary_bus.h             |   6 ++
>  9 files changed, 160 insertions(+), 348 deletions(-)
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20241210-aux-device-create-helper-93141524e523
>
> Best regards,

-- 
Jerome