linux-kernel - Re: [PATCH] nfsd: don't ignore the return code of svc_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173886723523.80292.10168370789662544077.b4-ty@oracle.com>
Date: Thu,  6 Feb 2025 13:41:00 -0500
From: cel@...nel.org
To: Neil Brown <neilb@...e.de>,
	Olga Kornievskaia <okorniev@...hat.com>,
	Dai Ngo <Dai.Ngo@...cle.com>,
	Tom Talpey <tom@...pey.com>,
	Josef Bacik <josef@...icpanda.com>,
	Jeff Layton <jlayton@...nel.org>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	syzbot+e34ad04f27991521104c@...kaller.appspotmail.com
Subject: Re: [PATCH] nfsd: don't ignore the return code of svc_proc_register()

From: Chuck Lever <chuck.lever@...cle.com>

On Thu, 06 Feb 2025 13:12:13 -0500, Jeff Layton wrote:
> Currently, nfsd_proc_stat_init() ignores the return value of
> svc_proc_register(). If the procfile creation fails, then the kernel
> will WARN when it tries to remove the entry later.
> 
> Fix nfsd_proc_stat_init() to return the same type of pointer as
> svc_proc_register(), and fix up nfsd_net_init() to check that and fail
> the nfsd_net construction if it occurs.
> 
> [...]

Applied to nfsd-testing, thanks!

Added Cc: stable # v6.9

[1/1] nfsd: don't ignore the return code of svc_proc_register()
      commit: 312aef1c1520c10cf035e27c0b0229bea71f0c68

--
Chuck Lever