linux-kernel - Re: [PATCH v2] ata: libahci_platform: support non-consecutive port numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <016bbf83fec9a0a7c7697462ce0970b94572f50c.camel@gmail.com>
Date: Thu, 06 Feb 2025 19:42:21 +0100
From: Klaus Kudielka <klaus.kudielka@...il.com>
To: Damien Le Moal <dlemoal@...nel.org>, Josua Mayer <josua@...id-run.com>, 
 Niklas Cassel <cassel@...nel.org>, Hans de Goede <hdegoede@...hat.com>
Cc: Jon Nettleton <jon@...id-run.com>, Mikhail Anikin	
 <mikhail.anikin@...id-run.com>, Yazan Shhady <yazan.shhady@...id-run.com>, 
 Rabeeh Khoury <rabeeh@...id-run.com>, linux-ide@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ata: libahci_platform: support non-consecutive port
 numbers

On Thu, 2025-02-06 at 10:34 +0900, Damien Le Moal wrote:
> 
> Can you try this to see if it restores the probe for the second port:
> 
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index 53b2c7719dc5..91d44302eac9 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -651,8 +651,6 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
>                  * If no sub-node was found, keep this for device tree
>                  * compatibility
>                  */
> -               hpriv->mask_port_map |= BIT(0);
> -
>                 rc = ahci_platform_get_phy(hpriv, 0, dev, dev->of_node);
>                 if (rc)
>                         goto err_out;
> 
> 

Yes, it does.

6.14.0-rc1 (plus patch above) bootlog
=====================================

Feb 06 19:31:51 spare kernel: ahci-mvebu f10a8000.sata: AHCI vers 0001.0000, 32 command slots, 6 Gbps, platform mode
Feb 06 19:31:51 spare kernel: ahci-mvebu f10a8000.sata: 2/2 ports implemented (port mask 0x3)
Feb 06 19:31:51 spare kernel: ahci-mvebu f10a8000.sata: flags: 64bit ncq sntf led only pmp fbs pio slum part sxs 
Feb 06 19:31:51 spare kernel: scsi host0: ahci-mvebu
Feb 06 19:31:51 spare kernel: scsi host1: ahci-mvebu
Feb 06 19:31:51 spare kernel: ata1: SATA max UDMA/133 mmio [mem 0xf10a8000-0xf10a9fff] port 0x100 irq 40 lpm-pol 0
Feb 06 19:31:51 spare kernel: ata2: SATA max UDMA/133 mmio [mem 0xf10a8000-0xf10a9fff] port 0x180 irq 40 lpm-pol 0


Tested-by: Klaus Kudielka <klaus.kudielka@...il.com>