linux-kernel - Re: [PATCH v1 1/1] scsi: lpfc: Switch to use %ptTs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6UGFoJbAGjI5VJW@smile.fi.intel.com>
Date: Thu, 6 Feb 2025 20:57:26 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: "Martin K. Petersen" <martin.petersen@...cle.com>,
	Justin Tee <justin.tee@...adcom.com>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	James Smart <james.smart@...adcom.com>,
	Dick Kennedy <dick.kennedy@...adcom.com>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>
Subject: Re: [PATCH v1 1/1] scsi: lpfc: Switch to use %ptTs

On Thu, Feb 06, 2025 at 05:52:16PM +0100, Thomas Weißschuh wrote:
> On Thu, Feb 06, 2025 at 05:58:22PM +0200, Andy Shevchenko wrote:

...

> >  	lpfc_printf_log(phba, KERN_INFO, LOG_CGN_MGMT,
> > -			"2646 Updated CMF timestamp : "
> > -			"%u/%u/%u %u:%u:%u\n",
> > -			ts->day, ts->month,
> > -			ts->year, ts->hour,
> > -			ts->minute, ts->second);
> > +			"2646 Updated CMF timestamp : %ptTs\n", cur_time);
> 
> All %p<FOO> arguments need to be addresses.
> Also %ptT wants a time64_t, not a 'struct timespec64'.
> It would work by chance because tv_sec is the first member and time64_t.
> 
> Correct: "&cur_time.tv_sec".

Indeed, thanks!

-- 
With Best Regards,
Andy Shevchenko