linux-kernel - Re: [PATCH v5 11/24] perf vendor events: Update/add Graniterapids events/metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0eb58c2-afba-4810-96d5-61f1c942ed57@linux.intel.com>
Date: Thu, 6 Feb 2025 13:59:43 -0500
From: "Liang, Kan" <kan.liang@...ux.intel.com>
To: Ian Rogers <irogers@...gle.com>
Cc: Thomas Falcon <thomas.falcon@...el.com>,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 Andreas Färber <afaerber@...e.de>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Weilin Wang <weilin.wang@...el.com>, linux-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, Perry Taylor <perry.taylor@...el.com>,
 Samantha Alt <samantha.alt@...el.com>,
 Caleb Biggers <caleb.biggers@...el.com>,
 Edward Baker <edward.baker@...el.com>, Michael Petlan <mpetlan@...hat.com>
Subject: Re: [PATCH v5 11/24] perf vendor events: Update/add Graniterapids
 events/metrics



On 2025-02-06 1:53 p.m., Liang, Kan wrote:
>>> However, when I dump the debug information,
>>> ./perf stat -M tma_frontend_bound -vvv
>>>
>>> I got below debug information. I have no idea where the slot is from.
>>> It seems the perf code mess up the p-core metrics with the e-core
>>> metrics. But why only slot?
>>> It seems a bug of perf tool.
>>>
>>> found event cpu_atom@..._CLK_UNHALTED.CORE@
>>> found event cpu_atom@...DOWN_FE_BOUND.ALL@
>>> found event slots
>>> Parsing metric events
>>>
>>> '{cpu_atom/CPU_CLK_UNHALTED.CORE,metric-id=cpu_atom!3CPU_CLK_UNHALTED.CORE!3/,cpu_atom/TOPDOWN_FE_BOUND.ALL,metric-id=cpu_atom!3TOPDOWN_FE_BOUND.ALL!3/,slots/metric-id=slots/}:W'
> It because the perf adds "slot" as a tool event for the e-core Topdown
> metrics.
> There is no "slot" event for e-core.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/
> tools/perf/util/metricgroup.c#n1481
> 
> I will check why "slot" event is added as a tool event for e-core?
> That doesn't make sense.


BTW: I checked the list of the tool events. Except the slots, others are
all SW (or non-HW) events which should always be available.
Slots is a HW event and only be available for p-core.
It doesn't look like a good fit here.

static const char *const tool_pmu__event_names[TOOL_PMU__EVENT_MAX] = {
	NULL,
	"duration_time",
	"user_time",
	"system_time",
	"has_pmem",
	"num_cores",
	"num_cpus",
	"num_cpus_online",
	"num_dies",
	"num_packages",
	"slots",
	"smt_on",
	"system_tsc_freq",
};

Thanks,
Kan