linux-kernel - Re: [PATCH v1 1/1] accel/habanalabs: Switch to use %ptTs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6UJ87h0QZ0HHmui@smile.fi.intel.com>
Date: Thu, 6 Feb 2025 21:13:55 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Ofir Bitton <obitton@...ana.ai>, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Cc: Oded Gabbay <ogabbay@...nel.org>
Subject: Re: [PATCH v1 1/1] accel/habanalabs: Switch to use %ptTs

On Thu, Feb 06, 2025 at 05:48:55PM +0200, Andy Shevchenko wrote:
> Use %ptTs instead of open-coded variant to print contents of time64_t type
> in human readable form.

...

>  		dev_err(hdev->dev,
> -			"EQ: {CI %u, HB counter %u, last HB time: %s}, PQ: {PI: %u, CI: %u (%u), last HB time: %s}\n",
> +			"EQ: {CI %u, HB counter %u, last HB time: %ptTs}, PQ: {PI: %u, CI: %u (%u), last HB time: %ptTs}\n",
>  			hdev->event_queue.ci,
>  			heartbeat_debug_info->heartbeat_event_counter,
> -			eq_time_str,
> +			hdev->heartbeat_debug_info.last_eq_heartbeat_ts,

This has to be a pointer...

>  			hdev->kernel_queues[cpu_q_id].pi,
>  			atomic_read(&hdev->kernel_queues[cpu_q_id].ci),
>  			atomic_read(&hdev->kernel_queues[cpu_q_id].ci) & pq_pi_mask,
> -			pq_time_str);
> +			hdev->heartbeat_debug_info.last_pq_heartbeat_ts);

...and this.

I will fix these typos in v2.

-- 
With Best Regards,
Andy Shevchenko