linux-kernel - Re: [PATCH v1 2/2] arm64: dts: qcom: ipq9574: Fix USB vdd info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ded2597-d5a1-44be-b5d2-30b70657730e@oss.qualcomm.com>
Date: Thu, 6 Feb 2025 20:40:43 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Varadarajan Narayanan <quic_varada@...cinc.com>, lgirdwood@...il.com,
        broonie@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
        conor+dt@...nel.org, andersson@...nel.org, konradybcio@...nel.org,
        agross@...nel.org, dmitry.baryshkov@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Cc: stable@...r.kernel.org
Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: ipq9574: Fix USB vdd info

On 5.02.2025 8:46 AM, Varadarajan Narayanan wrote:
> USB phys in ipq9574 use the 'L5' regulator. The commit
> ec4f047679d5 ("arm64: dts: qcom: ipq9574: Enable USB")
> incorrectly specified it as 'L2'. Because of this when the phy
> module turns off/on its regulators, 'L2' is turned off/on
> resulting in 2 issues, namely 'L5' is not turned off/on and the
> network module powered by the 'L2' is turned off/on.

Please wrap your lines at ~72 chars

You use "'L5'" and "'L2'" a lot, making it hard to read. Try focusing
on the effect.

Konrad