linux-kernel - Re: [PATCH 1/3] compiler.h: Move C string helpers into C-only kernel section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nmAKa4rHsk0s1iqY77T-0MEyA8UJv1y=w9vFQ79FBxSw@mail.gmail.com>
Date: Thu, 6 Feb 2025 21:07:05 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Kees Cook <kees@...nel.org>
Cc: Suren Baghdasaryan <surenb@...gle.com>, Kent Overstreet <kent.overstreet@...ux.dev>, 
	Andy Shevchenko <andy@...nel.org>, Luc Van Oostenryck <luc.vanoostenryck@...il.com>, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, 
	Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, 
	Philipp Reisner <philipp.reisner@...bit.com>, Miguel Ojeda <ojeda@...nel.org>, 
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, 
	llvm@...ts.linux.dev
Subject: Re: [PATCH 1/3] compiler.h: Move C string helpers into C-only kernel section

On Thu, Feb 6, 2025 at 7:11 PM Kees Cook <kees@...nel.org> wrote:
>
> The C kernel helpers for evaluating C Strings were placed outside of the
> assembly ifdef. Move them to the correct place so future changes won't
> confuse the assembler.

This moves it also into the kernel ifdef too -- I assume that is
intentional. (Perhaps mention ifndef instead of ifdef?)

I checked that this is indeed a pure move, so:

Reviewed-by: Miguel Ojeda <ojeda@...nel.org>

Cheers,
Miguel