linux-kernel - [PATCH v3 2/6] rust: error: add missing newline to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250206-printing_fix-v3-2-a85273b501ae@invicto.ai>
Date: Thu, 06 Feb 2025 21:07:53 +0000 (UTC)
From: Alban Kurti <kurti@...icto.ai>
To: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
 Benno Lossin <benno.lossin@...ton.me>, 
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
 Trevor Gross <tmgross@...ch.edu>, Jonathan Corbet <corbet@....net>, 
 David Gow <davidgow@...gle.com>, Dirk Behme <dirk.behme@...bosch.com>, 
 Asahi Lina <lina@...hilina.net>, Wedson Almeida Filho <wedsonaf@...il.com>, 
 Wedson Almeida Filho <walmeida@...rosoft.com>, 
 "Andreas Hindborg (Samsung)" <nmi@...aspace.dk>, Tejun Heo <tj@...nel.org>, 
 Fiona Behrens <me@...enk.dev>, 
 Vincenzo Palazzo <vincenzopalazzodev@...il.com>, 
 Xiangfei Ding <dingxiangfei2009@...il.com>
Cc: rust-for-linux@...r.kernel.org, linux-doc@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Alban Kurti <kurti@...icto.ai>, 
 Martin Rodriguez Reboredo <yakoyoku@...il.com>, 
 Fox Chen <foxhlchen@...il.com>
Subject: [PATCH v3 2/6] rust: error: add missing newline to pr_warn! calls

Added missing newline at the end of pr_warn! usage
so the log is not missed.

Fixes: 6551a7fe0acb ("rust: error: Add Error::from_errno{_unchecked}()")
Reported-by: Miguel Ojeda <ojeda@...nel.org>
Closes: https://github.com/Rust-for-Linux/linux/issues/1139
Signed-off-by: Alban Kurti <kurti@...icto.ai>
---
 rust/kernel/error.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
index f6ecf09cb65f4ebe9b88da68b3830ae79aa4f182..a194d83e6835c03b84cc849b641ce8fff548047d 100644
--- a/rust/kernel/error.rs
+++ b/rust/kernel/error.rs
@@ -107,7 +107,7 @@ pub fn from_errno(errno: crate::ffi::c_int) -> Error {
         } else {
             // TODO: Make it a `WARN_ONCE` once available.
             crate::pr_warn!(
-                "attempted to create `Error` with out of range `errno`: {}",
+                "attempted to create `Error` with out of range `errno`: {}\n",
                 errno
             );
             code::EINVAL

-- 
2.48.1