linux-kernel - Re: [PATCH] x86: rust: set rustc-abi=x86-softfloat on rustc>=1.86.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kYzZ5T0Y1PMmz8dcu5FEwuS+xkUPprnw-qawy1WHEMsA@mail.gmail.com>
Date: Thu, 6 Feb 2025 23:23:42 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Dave Hansen <dave.hansen@...el.com>
Cc: Alice Ryhl <aliceryhl@...gle.com>, x86@...nel.org, rust-for-linux@...r.kernel.org, 
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, 
	Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, 
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] x86: rust: set rustc-abi=x86-softfloat on rustc>=1.86.0

On Thu, Feb 6, 2025 at 9:58 PM Dave Hansen <dave.hansen@...el.com> wrote:
>
> Are you saying you'd prefer that we pick this up on the x86 side? I'm
> totally happy to do that, and it's obviously patching x86-specific
> sections of the rust scripts.
>
> If I'm understanding the ask.... Just curious though, what makes that
> preferable? It's in a rust-specific file
> (scripts/generate_rust_target.rs) and I'd guess that it'd be easier to
> take it through the rust tree since it's more likely to collide with
> stuff there and also be closer to the folks that can competently resolve
> any merge problems.

I typically say something like that when I feel I may be overstepping
-- I don't want other subsystems to feel that they are being skipped.
For x86 I have so far taken things myself, since it was the first Rust
arch (so it was an exceptional case), but perhaps you wanted to start
handling things on your own etc.

I am happy either way, of course. Your Acked-by's would be very welcome!

Cheers,
Miguel