linux-kernel - [PATCH] platform/x86: samsung-galaxybook: Fix sysfs_attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250206225707.12962-1-josh@joshuagrisham.com>
Date: Thu,  6 Feb 2025 23:57:07 +0100
From: Joshua Grisham <josh@...huagrisham.com>
To: markgross@...nel.org,
	ilpo.jarvinen@...ux.intel.com,
	hdegoede@...hat.com,
	platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: W_Armin@....de,
	thomas@...ch.de,
	kuurtb@...il.com,
	Joshua Grisham <josh@...huagrisham.com>
Subject: [PATCH] platform/x86: samsung-galaxybook: Fix sysfs_attr_init of fw attrs

Fixes sysfs_attr_init bug in samsung-galaxybook as reported in [1].

Should be applied after
  commit f97634611408 ("platform/x86: samsung-galaxybook: Add samsung-galaxybook driver")

Tested with CONFIG_DEBUG_LOCK_ALLOC=y on a Samsung Galaxy Book2 Pro.

[1]: https://lore.kernel.org/linux-next/20250206133652.71bbf1d3@canb.auug.org.au/

Signed-off-by: Joshua Grisham <josh@...huagrisham.com>
---
 drivers/platform/x86/samsung-galaxybook.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x86/samsung-galaxybook.c
index 9c658a45d..de1ed2dc6 100644
--- a/drivers/platform/x86/samsung-galaxybook.c
+++ b/drivers/platform/x86/samsung-galaxybook.c
@@ -1011,13 +1011,13 @@ static int galaxybook_fw_attr_init(struct samsung_galaxybook *galaxybook,
 	attrs[2] = &fw_attr_possible_values.attr;
 	attrs[3] = &fw_attr_display_name_language_code.attr;
 
-	sysfs_attr_init(&fw_attr.display_name);
+	sysfs_attr_init(&fw_attr->display_name.attr);
 	fw_attr->display_name.attr.name = "display_name";
 	fw_attr->display_name.attr.mode = 0444;
 	fw_attr->display_name.show = display_name_show;
 	attrs[4] = &fw_attr->display_name.attr;
 
-	sysfs_attr_init(&fw_attr.current_value);
+	sysfs_attr_init(&fw_attr->current_value.attr);
 	fw_attr->current_value.attr.name = "current_value";
 	fw_attr->current_value.attr.mode = 0644;
 	fw_attr->current_value.show = current_value_show;
-- 
2.45.2