linux-kernel - Re: [PATCH v3 1/2] rust: lockdep: Remove support for dynamically allocated LockClassKeys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kawfy3YYyo7ANYrKVjkh0n53Jt_d0=bHqHfirHCxe6_Q@mail.gmail.com>
Date: Fri, 7 Feb 2025 00:27:58 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Mitchell Levy <levymitchell0@...il.com>
Cc: Boqun Feng <boqun.feng@...il.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Andreas Hindborg <a.hindborg@...nel.org>, linux-block@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH v3 1/2] rust: lockdep: Remove support for dynamically
 allocated LockClassKeys

On Wed, Feb 5, 2025 at 8:59 PM Mitchell Levy <levymitchell0@...il.com> wrote:
>
> Currently, dynamically allocated LockCLassKeys can be used from the Rust
> side without having them registered. This is a soundness issue, so
> remove them.
>
> Suggested-by: Alice Ryhl <aliceryhl@...gle.com>
> Link: https://lore.kernel.org/rust-for-linux/20240815074519.2684107-3-nmi@metaspace.dk/
> Cc: stable@...r.kernel.org
> Signed-off-by: Mitchell Levy <levymitchell0@...il.com>

I imagine we should have:

    Fixes: 6ea5aa08857a ("rust: sync: introduce `LockClassKey`")

Is that right?

Thanks!

Cheers,
Miguel