linux-kernel - Re: [RESEND v5 3/4] soundwire: qcom: Add set_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffbd8209-116a-a4ad-1b5a-cd61665758fd@quicinc.com>
Date: Thu, 6 Feb 2025 10:59:00 +0530
From: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
To: Mark Brown <broonie@...nel.org>
CC: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Liam Girdwood
	<lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Vinod Koul
	<vkoul@...nel.org>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        "Jaroslav
 Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart
	<pierre-louis.bossart@...ux.dev>,
        Sanyog Kale <sanyog.r.kale@...el.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-sound@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_pkumpatl@...cinc.com>,
        <kernel@...cinc.com>
Subject: Re: [RESEND v5 3/4] soundwire: qcom: Add set_channel_map api support

On 2/3/2025 6:49 PM, Mark Brown wrote:
> On Thu, Jan 23, 2025 at 09:58:22AM +0530, Mohammad Rafi Shaik wrote:
>> Added qcom_swrm_set_channel_map api to set the master channel mask for
>> TX and RX paths based on the provided slots.
> 
> This breaks an allmodconfig build, and arm64 defconfig:
> 
> /build/stage/linux/drivers/soundwire/qcom.c: In function ‘qcom_swrm_set_channel_map’:
> /build/stage/linux/drivers/soundwire/qcom.c:1283:36: warning: unused variable ‘sruntime’ [-Wunused-variable]
>   1283 |         struct sdw_stream_runtime *sruntime = ctrl->sruntime[dai->id];
>        |                                    ^~~~~~~~
> /build/stage/linux/drivers/soundwire/qcom.c: At top level:
> /build/stage/linux/drivers/soundwire/qcom.c:1335:28: error: initialization of ‘int (*)(struct snd_soc_dai *, unsigned int,  const unsigned int *, unsigned int,  const unsigned int *)’ from incompatible pointer type ‘int (*)(struct snd_soc_dai *, unsigned int,  unsigned int *, unsigned int,  unsigned int *)’ [-Werror=incompatible-pointer-types]
>   1335 |         .set_channel_map = qcom_swrm_set_channel_map,
>        |                            ^~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/drivers/soundwire/qcom.c:1335:28: note: (near initialization for ‘qcom_swrm_pdm_dai_ops.set_channel_map’)

ACK,

Thanks for the review and test.

Somehow above build errors not reproduced in my build setup.

I am Using below commands for build:
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- allmodconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j32

Will check and fix in next version.

Thanks & Regards,
Rafi