linux-kernel - Re: [PATCH v3 3/8] scsi: ufs: core: Add a vop to map clock frequency to gear speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5595f528-c342-4ae3-823f-6fb44ddc73fa@quicinc.com>
Date: Thu, 6 Feb 2025 15:47:39 +0800
From: Ziqi Chen <quic_ziqichen@...cinc.com>
To: Bean Huo <huobean@...il.com>, <quic_cang@...cinc.com>,
        <bvanassche@....org>, <mani@...nel.org>, <beanhuo@...ron.com>,
        <avri.altman@....com>, <junwoo80.lee@...sung.com>,
        <martin.petersen@...cle.com>, <quic_nguyenb@...cinc.com>,
        <quic_nitirawa@...cinc.com>, <quic_rampraka@...cinc.com>
CC: <linux-arm-msm@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        Alim Akhtar
	<alim.akhtar@...sung.com>,
        "James E.J. Bottomley"
	<James.Bottomley@...senPartnership.com>,
        Peter Wang
	<peter.wang@...iatek.com>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>,
        Eric Biggers <ebiggers@...gle.com>, Minwoo Im <minwoo.im@...sung.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/8] scsi: ufs: core: Add a vop to map clock frequency
 to gear speed



On 2/3/2025 8:55 PM, Bean Huo wrote:
> On Mon, 2025-02-03 at 16:11 +0800, Ziqi Chen wrote:
>> From: Can Guo <quic_cang@...cinc.com>
>>
>> Add a vop to map UFS host controller clock frequencies to the maximum
>> supported UFS high speed gear speeds.
> 
>  From the code, seems it is not "maximum" gear, it is corresponding UFS
> Gear.
> 

Hi Bean,

Thank you for comment. Let me explain for you that why it is "maximum 
supported" gear.

For example, the freq 201500000 supports G1 G2 G3， this VOP will maps to 
G3 which is the "maximum supported" gear.

Maybe we can change it to "corresponding maximum supported" gear would 
be more make sense.

Let me change it in next version.

-Ziqi

>> During clock scaling, we canmap thetarget clock frequency, demanded
>> by devfreq, to the maximum supported gear
>> speed, so that devfreq can scale the gear to the highest gear speed
>> supported at the target clock frequency, instead of just scaling
>> up/down
>> the gear between the min and max gear speeds.
>>
>> Co-developed-by: Ziqi Chen <quic_ziqichen@...cinc.com>
>> Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>
>> Signed-off-by: Can Guo <quic_cang@...cinc.com>
> 
> Reveiwed-by: Bean Huo <beanhuo@...ron.com>