linux-kernel - Re: [PATCH 12/12] Documentation: Update the todo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73bad044-f5fc-40ea-9e32-571912573a5f@suse.de>
Date: Thu, 6 Feb 2025 08:57:10 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Anusha Srivatsa <asrivats@...hat.com>, Joel Stanley <joel@....id.au>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Andrew Jeffery
 <andrew@...econstruct.com.au>, Stefan Agner <stefan@...er.ch>,
 Alison Wang <alison.wang@....com>, Xinliang Liu <xinliang.liu@...aro.org>,
 Tian Tao <tiantao6@...ilicon.com>,
 Xinwei Kong <kong.kongxinwei@...ilicon.com>,
 Sumit Semwal <sumit.semwal@...aro.org>, Yongqin Liu
 <yongqin.liu@...aro.org>, John Stultz <jstultz@...gle.com>,
 Chun-Kuang Hu <chunkuang.hu@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Marek Vasut <marex@...x.de>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Sandy Huang <hjc@...k-chips.com>,
 Heiko Stübner <heiko@...ech.de>,
 Andy Yan <andy.yan@...k-chips.com>, Orson Zhai <orsonzhai@...il.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 Chunyan Zhang <zhang.lyra@...il.com>, Alain Volmat
 <alain.volmat@...s.st.com>, Raphael Gallais-Pou <rgallaispou@...il.com>,
 Yannick Fertre <yannick.fertre@...s.st.com>,
 Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>,
 Philippe Cornu <philippe.cornu@...s.st.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Thierry Reding <thierry.reding@...il.com>,
 Mikko Perttunen <mperttunen@...dia.com>,
 Jonathan Hunter <jonathanh@...dia.com>,
 Alexey Brodkin <abrodkin@...opsys.com>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Maíra Canal <mcanal@...lia.com>,
 Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Jonathan Corbet <corbet@....net>
Cc: linux-aspeed@...ts.ozlabs.org, dri-devel@...ts.freedesktop.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, imx@...ts.linux.dev,
 linux-rockchip@...ts.infradead.org,
 linux-stm32@...md-mailman.stormreply.com, linux-tegra@...r.kernel.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH 12/12] Documentation: Update the todo

Hi


Am 05.02.25 um 21:08 schrieb Anusha Srivatsa:
> Update the Documentation to be more precise.
>
> v2: Update for clarity
>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Signed-off-by: Anusha Srivatsa <asrivats@...hat.com>
> ---
>   Documentation/gpu/todo.rst | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 256d0d1cb2164bd94f9b610a751b907834d96a21..03fcd086889acbd1294669b260292ffc79e97e2f 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -441,13 +441,13 @@ Contact: Thomas Zimmermann <tzimmermann@...e.de>
>   
>   Level: Intermediate
>   
> -Request memory regions in all drivers
> --------------------------------------
> +Request memory regions in all fbdev drivers
> +--------------------------------------------
>   
> -Go through all drivers and add code to request the memory regions that the
> -driver uses. This requires adding calls to request_mem_region(),
> -pci_request_region() or similar functions. Use helpers for managed cleanup
> -where possible.
> +Old/ancient fbdev drivers do not request their memory properly.
> +Go through these drivers and add code to request the memory regions that the
> +driver uses. Problematic areas include hardware that has exclusive ranges like
> +VGA. VGA16fb does not request the range as it is expected.

I'd keep both, old and new text, and turn them into a single paragraph. 
The old text explains what to do and the new text gives examples.

Best regards
Thomas

>   
>   Drivers are pretty bad at doing this and there used to be conflicts among
>   DRM and fbdev drivers. Still, it's the correct thing to do.
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)