linux-kernel - Re: [PATCH] can: etas_es58x: fix potential NULL pointer dereference on udev->serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250206-romantic-sloth-of-ecstasy-de9305-mkl@pengutronix.de>
Date: Thu, 6 Feb 2025 09:01:08 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc: linux-can@...r.kernel.org, linux-kernel@...r.kernel.org, 
	yan kang <kangyan91@...look.com>, yue sun <samsun1006219@...il.com>
Subject: Re: [PATCH] can: etas_es58x: fix potential NULL pointer dereference
 on udev->serial

On 05.02.2025 00:48:15, Vincent Mailhol wrote:
> The driver assumed that es58x_dev->udev->serial could never be NULL.
> While this is true on commercially available devices, an attacker
> could spoof the device identity providing a NULL USB serial number.
> That would trigger a NULL pointer dereference.
> 
> Add a check on es58x_dev->udev->serial before accessing it.
> 
> Reported-by: yan kang <kangyan91@...look.com>
> Reported-by: yue sun <samsun1006219@...il.com>
> Closes: https://lore.kernel.org/linux-can/SY8P300MB0421E0013C0EBD2AA46BA709A1F42@SY8P300MB0421.AUSP300.PROD.OUTLOOK.COM/
> Fixes: 9f06631c3f1f ("can: etas_es58x: export product information through devlink_ops::info_get()")
> Signed-off-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>

Applied to linux-can.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)