linux-kernel - Re: [PATCH v2 1/5] dt-bindings: ROHM BD79124 ADC/GPO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76858097-10a8-403d-83a1-f70064f97a6c@gmail.com>
Date: Thu, 6 Feb 2025 10:39:19 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
 Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Nuno Sa <nuno.sa@...log.com>,
 David Lechner <dlechner@...libre.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: ROHM BD79124 ADC/GPO

On 05/02/2025 22:03, Conor Dooley wrote:
> On Wed, Feb 05, 2025 at 03:34:29PM +0200, Matti Vaittinen wrote:
>> Add binding document for the ROHM BD79124 ADC / GPO.
>>
>> ROHM BD79124 is a 8-channel, 12-bit ADC. The input pins can also be used
>> as general purpose outputs.
>>
>> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
>> ---
>> Revision history:
>> RFC v1 => v2:
>>   - drop MFD and represent directly as ADC
>>   - drop pinmux and treat all non ADC channel pins as GPOs
>> ---

...

>> +patternProperties:
>> +  "^channel@[0-9a-f]+$":
> 
> You can only have 8 channels, there's no need for this to be so
> permissive, right?
> Otherwise, this looks good enough to me.

Thanks Conor!

Indeed, I think we only need to accept channel@0 .. channel@7. Thanks!
(And reason for this being permissive is ... drum roll ... copy-paste :) 
That's my main method of creating the yaml bindings. Swearing, sweating, 
copying and running the 'make dt_binding_check'
:rolleyes:

I'll wait for a while for comments to the other patches and fix this for 
v3 :)

Yours,
	-- Matti