linux-kernel - Re: [PATCH v6 2/3] firmware: add Exynos ACPM protocol driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1fa54c76-d82f-483b-b577-79322908fabc@linaro.org>
Date: Thu, 6 Feb 2025 09:02:11 +0000
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Jassi Brar <jassisinghbrar@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 andre.draszik@...aro.org, kernel-team@...roid.com, willmcvicker@...gle.com,
 peter.griffin@...aro.org, daniel.lezcano@...aro.org,
 vincent.guittot@...aro.org, ulf.hansson@...aro.org, arnd@...db.de
Subject: Re: [PATCH v6 2/3] firmware: add Exynos ACPM protocol driver



On 2/5/25 4:52 PM, Krzysztof Kozlowski wrote:
>> +static const struct acpm_handle *acpm_get_by_phandle(struct device *dev)
> "by_phandle" takes the name of the property with phandle as an argument,
> because otherwise you do not have here phandle part at all in the
> interface (see syscon API).
> 

Indeed.

> Other option would be by actual phandle - see of_find_node_by_phandle().
> 
> I would propose in such case only acpm_get() or maybe better of_acpm_get()?
> 
>> +{

cut

>> +	np = of_parse_phandle(dev->of_node, "exynos,acpm_ipc", 0);
> You need bindings for this somewhere and fix the underscore->hyphen...
> and vendor prefix. It really would not be accepted that way so please
> post consumer bindings anywhere.

There's no consumer upstreamed yet, I don't know where I shall specify
it. How about keeping the function name and modify the declaration to

+static const struct acpm_handle *acpm_get_by_phandle(struct device_node
*np,
+						     const char *property)

This shall be in line with the syscon API and doesn't force me to
introduce bindings for the consumers now.

Thanks!
ta