linux-kernel - Re: [PATCH net-next v4] netdev-genl: Elide napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKgEd+T717kP=Bq7cSssr8ibh5t-+g6Ztybd+mkJFt8mg@mail.gmail.com>
Date: Thu, 6 Feb 2025 10:02:27 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Joe Damato <jdamato@...tly.com>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, sridhar.samudrala@...el.com, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>, 
	Amritha Nambiar <amritha.nambiar@...el.com>, Mina Almasry <almasrymina@...gle.com>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v4] netdev-genl: Elide napi_id when not present

On Wed, Feb 5, 2025 at 8:38 PM Joe Damato <jdamato@...tly.com> wrote:
>
> There are at least two cases where napi_id may not present and the
> napi_id should be elided:
>
> 1. Queues could be created, but napi_enable may not have been called
>    yet. In this case, there may be a NAPI but it may not have an ID and
>    output of a napi_id should be elided.
>
> 2. TX-only NAPIs currently do not have NAPI IDs. If a TX queue happens
>    to be linked with a TX-only NAPI, elide the NAPI ID from the netlink
>    output as a NAPI ID of 0 is not useful for users.
>
> Signed-off-by: Joe Damato <jdamato@...tly.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>