linux-kernel - Re: [PATCH rdma-next 1/1] RDMA/mana

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250206090828.GP74886@unreal>
Date: Thu, 6 Feb 2025 11:08:28 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Konstantin Taranov <kotaranov@...ux.microsoft.com>
Cc: kotaranov@...rosoft.com, shirazsaleem@...rosoft.com,
	sharmaajay@...rosoft.com, longli@...rosoft.com, jgg@...pe.ca,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: Add port statistics support

On Wed, Feb 05, 2025 at 02:32:07AM -0800, Konstantin Taranov wrote:
> From: Shiraz Saleem <shirazsaleem@...rosoft.com>
> 
> Implement alloc_hw_port_stats and get_hw_stats APIs to support querying
> MANA VF port level statistics from rdma stat tool.
> 
> Example output from rdma stat tool:
> 
> $rdma statistic show link mana_0/1 -p
> link mana_0/1
>     requester_timeout 45
>     requester_oos_nak 0
>     requester_rnr_nak 0
>     responder_rnr_nak 0
>     responder_oos 0
>     responder_dup_request 0
>     requester_implicit_nak 0
>     requester_readresp_psn_mismatch 0
>     nak_inv_req 0
>     nak_access_error 0
>     nak_opp_error 0
>     nak_inv_read 0
>     responder_local_len_error 0
>     requestor_local_prot_error 0
>     responder_rem_access_error 0
>     responder_local_qp_error 0
>     responder_malformed_wqe 0
>     general_hw_error 6
>     requester_rnr_nak_retries_exceeded 0
>     requester_retries_exceeded 5
>     total_fatal_error 6
>     received_cnps 0
>     num_qps_congested 0
>     rate_inc_events 0
>     num_qps_recovered 0
>     current_rate 100000
> 
> Signed-off-by: Shiraz Saleem <shirazsaleem@...rosoft.com>
> Signed-off-by: Konstantin Taranov <kotaranov@...rosoft.com>
> ---
>  drivers/infiniband/hw/mana/Makefile   |   2 +-
>  drivers/infiniband/hw/mana/counters.c | 105 ++++++++++++++++++++++++++
>  drivers/infiniband/hw/mana/counters.h |  44 +++++++++++
>  drivers/infiniband/hw/mana/device.c   |   7 ++
>  drivers/infiniband/hw/mana/mana_ib.h  |  61 ++++++++++++---
>  5 files changed, 206 insertions(+), 13 deletions(-)
>  create mode 100644 drivers/infiniband/hw/mana/counters.c
>  create mode 100644 drivers/infiniband/hw/mana/counters.h

<...>

>  enum mana_ib_command_code {
> -	MANA_IB_GET_ADAPTER_CAP = 0x30001,
> -	MANA_IB_CREATE_ADAPTER  = 0x30002,
> -	MANA_IB_DESTROY_ADAPTER = 0x30003,
> -	MANA_IB_CONFIG_IP_ADDR	= 0x30004,
> -	MANA_IB_CONFIG_MAC_ADDR	= 0x30005,
> -	MANA_IB_CREATE_UD_QP	= 0x30006,
> -	MANA_IB_DESTROY_UD_QP	= 0x30007,
> -	MANA_IB_CREATE_CQ       = 0x30008,
> -	MANA_IB_DESTROY_CQ      = 0x30009,
> -	MANA_IB_CREATE_RC_QP    = 0x3000a,
> -	MANA_IB_DESTROY_RC_QP   = 0x3000b,
> -	MANA_IB_SET_QP_STATE	= 0x3000d,
> +	MANA_IB_GET_ADAPTER_CAP		= 0x30001,
> +	MANA_IB_CREATE_ADAPTER		= 0x30002,
> +	MANA_IB_DESTROY_ADAPTER		= 0x30003,
> +	MANA_IB_CONFIG_IP_ADDR		= 0x30004,
> +	MANA_IB_CONFIG_MAC_ADDR		= 0x30005,
> +	MANA_IB_CREATE_UD_QP		= 0x30006,
> +	MANA_IB_DESTROY_UD_QP		= 0x30007,
> +	MANA_IB_CREATE_CQ		= 0x30008,
> +	MANA_IB_DESTROY_CQ		= 0x30009,
> +	MANA_IB_CREATE_RC_QP		= 0x3000a,
> +	MANA_IB_DESTROY_RC_QP		= 0x3000b,
> +	MANA_IB_SET_QP_STATE		= 0x3000d,
> +	MANA_IB_QUERY_VF_COUNTERS	= 0x30022,
>  };

Please stop to do vertical alignment. We don't need this churn.
I fixed it locally.

Thanks